scripts: add --go-ldflags argument to operator-sdk build command

[ZoltanOnody]

Description of the change:
Add --go-ldflags support to operator-sdk build command

Motivation for the change:
I need to provide build time arguments to my operator such as version. With this MR I am able to run:

operator-sdk build image-name --go-ldflags "-X package.Version=vX.Y.Z"

Fixes #1435

[openshift-ci-robot]

Hi @ZoltanOnody. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lilic]

Hi thanks for your PR! I am wondering if we can make this more generic, but allowing the user to pass in additional go build args in a similar way as we do with imageBuildArgs.

[ZoltanOnody]

Sure, I'll have a look at it.

[ZoltanOnody]

I generalized it & amended my commit, now we can provide any additional arguments. Now it works like:

operator-sdk build image-name --go-build-args "-ldflags -X=package.Version=vX.Y.Z"

[lilic]

@ZoltanOnody thanks so much!

/ok-to-test

[lilic]

You can ignore the marker test, it seems to be behaving oddly right now. But the e2e test seems to be failing as well.

[shawn-hurley]

/retest

[ZoltanOnody]

The test seems to be working locally:

+ kubectl create namespace test-memcached
namespace/test-memcached created
+ operator-sdk test local ./test/e2e --up-local --namespace=test-memcached
INFO[0000] Testing operator locally.                    
ok  	github.com/operator-framework/operator-sdk/test/test-framework/test/e2e	47.360s
INFO[0049] Local operator test successfully completed.  

In Travis I see:

+operator-sdk test local ./test/e2e --up-local --namespace=test-memcached
INFO[0000] Testing operator locally.                    
time="2019-06-21T17:22:13Z" level=info msg="Started local operator"
--- FAIL: TestMemcached (80.15s)
    --- FAIL: TestMemcached/memcached-group (0.00s)
        --- FAIL: TestMemcached/memcached-group/Cluster2 (60.02s)
            memcached_test.go:100: Initialized cluster resources
            wait_util.go:48: Operator is running locally; skip waitForDeployment
            client.go:57: resource type  with namespace/name (test-memcached/example-memcached) created
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            wait_util.go:64: Waiting for full availability of example-memcached deployment (0/3)
            memcached_test.go:114: timed out waiting for the condition
            client.go:75: resource type  with namespace/name (test-memcached/example-memcached) successfully deleted
FAIL

I think is just some random error caused by network issues in Travis. Could you please restart the job https://travis-ci.org/operator-framework/operator-sdk/jobs/548782267?

[lilic]

@ZoltanOnody retriggered that test.
Can you also rebase to current master, the marker test should be fixed by doing that, thanks for your patience!

[ZoltanOnody]

I rebased my branch and forcepushed it. When you retriggered the job, it passed so the failing test was not caused by my changes. :)

[shawn-hurley]

/lgtm

[joelanford]

Just one nit with the CHANGELOG line.

[lilic]

lgtm after that one small suggestion by Joe.

Thanks so much for your contribution and patience!

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[ZoltanOnody]

Is it OK to change it using "Commit suggestion" via Github (I've seen this feature for the first time), or should a squash my commits locally and force push?

BTW, do you have any ETA for the next release of operator-sdk?

[joelanford]

Is it OK to change it using "Commit suggestion" via Github (I've seen this feature for the first time), or should a squash my commits locally and force push?

Yep. Using "commit suggestion" is totally fine. When one of the maintainers actually does the merge, GitHub automatically squahes everything for us, so you don't have to squash and force push.

BTW, do you have any ETA for the next release of operator-sdk?

Probably later this week unless something comes up that forces us to push it back.

[joelanford]

/approve

[hasbro17]

LGTM

Thanks for adding this in.