pkg/metrics: pass rest.Config to avoid flag issue in library #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
requested review from
AlexNPavel,
lilic,
hasbro17,
theishshah and
estroz
openshift-ci-robot
added
the
size/M
estroz
reviewed
Jul 1, 2019
|
@AlexNPavel @lilic will this resolve the issue that we discussed offline? |
AlexNPavel
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
rest.Configtometrics.CreateMetricsServicefunction and remove code frommetricspackage that usescontroller-runtime's config package to get config.Motivation for the change:
controller-runtime's config package declares flags forkubeconfigandmasterAPI server, which is causing problems due to double flag declarations in the test framework.