internal/olm: get installed version from cluster instead of required CLI argument #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/M
|
@estroz Makes sense to me to use it for uninstall. |
…) in Manager.Status()
--version is only used with Install. internal/olm/manager.go: use Client.GetInstalledVersion() in Manager.Uninstall() instead of requiring version.
estroz
force-pushed
the
olm-get-installed-version
branch
2 times, most recently
from
5affa6a
to
4fdf055
Compare
estroz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
joelanford
approved these changes
Jul 2, 2019
|
@joelanford indeed they do: operator-framework/operator-lifecycle-manager#935. |
estroz
force-pushed
the
olm-get-installed-version
branch
from
4fdf055
to
3db2094
Compare
|
New changes are detected. LGTM label has been removed. |
Co-Authored-By: Joe Lanford <joe.lanford@gmail.com>
|
/test e2e-aws-ansible |
openshift-ci-robot
added
size/L
estroz
commented
Jul 22, 2019
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
estroz
changed the title
|
@estroz Can you also update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: get the version of OLM installed in a cluster without passing
--version=<version>toolm status.Motivation for the change: a user may not know which OLM version was installed in a cluster.
@joelanford we might be able to use
Client.GetInstalledVersion()inUninstall()too.