internal/pkg/scaffold/crd.go: remove CRD cache #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generated with the correct domain
openshift-ci-robot
added
the
size/M
hasbro17
approved these changes
Jul 2, 2019
|
/test e2e-aws-ansible |
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 19, 2019
* internal/pkg/scaffold/crd.go: remove CRD cache so manifests are generated with the correct domain * CHANGELOG.md: bug fix for CRD domain names
estroz
pushed a commit
that referenced
this pull request
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: remove CRD cache so manifests are generated with the correct domain.
Motivation for the change: Fixes #1608. The cache didn't provide a big performance benefit anyway unless quite a few API's require parsing. This is also not an issue in controller-tools v0.2.0 CRD generator.
Closes #1608