pkg/ready: Make set/unset idempotent #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
mhrivnak
approved these changes
Jul 31, 2019
|
@djzager Can you update the CHANGELOG to document this change? |
joelanford
reviewed
Jul 31, 2019
joelanford
approved these changes
Jul 31, 2019
estroz
suggested changes
Aug 1, 2019
djzager
commented
Aug 2, 2019
|
@estroz do you have any more changes you would like for me to make? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1760
Description of the change:
Make the ready package idempotent.
Motivation for the change:
As a user, I would expect the cases where I set the operator as ready or unset the operator's readiness to be a no-op in the cases that the operator is already in said state.