Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(olm-catalog) : Generated alm-examples in a pretty format #1793

Merged
merged 3 commits into from
Aug 12, 2019
Merged

feat(olm-catalog) : Generated alm-examples in a pretty format #1793

merged 3 commits into from
Aug 12, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Aug 7, 2019 •
edited
Loading

Description of the change:
Generated alm-examples for olm in a pretty format.

Motivation for the change:

Tests performed locally:

Screenshot 2019-08-08 at 08 24 59

Screenshot 2019-08-08 at 08 23 40

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2019
@openshift-ci-robot
Copy link

Hi @camilamacedo86. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 mentioned this pull request Aug 7, 2019
Closed
@camilamacedo86 camilamacedo86 changed the title feat(olm-catalog) : Generated alm-examples in a pretty format WIP: feat(olm-catalog) : Generated alm-examples in a pretty format Aug 7, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2019
@camilamacedo86 camilamacedo86 reopened this Aug 8, 2019
@camilamacedo86 camilamacedo86 force-pushed the ISSUE_1708 branch 2 times, most recently from 0002928 to 4bfa852 Compare August 8, 2019 07:29
@camilamacedo86 camilamacedo86 changed the title WIP: feat(olm-catalog) : Generated alm-examples in a pretty format feat(olm-catalog) : Generated alm-examples in a pretty format Aug 8, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2019
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 8, 2019 •
edited
Loading

Hi @joelanford,

Really tks for your help. It is working now. Please, feel free to review.
Now we need to ensure that it will still be working after this change. Do you know if the e2e tests are covering it?

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2019
estroz
estroz suggested changes Aug 9, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

CHANGELOG.md Outdated Show resolved Hide resolved
internal/pkg/scaffold/olm-catalog/csv_updaters.go Outdated Show resolved Hide resolved
internal/pkg/scaffold/olm-catalog/csv_updaters.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2019
@camilamacedo86 camilamacedo86 force-pushed the ISSUE_1708 branch 2 times, most recently from 40e5b84 to 5973f7c Compare August 11, 2019 09:57
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 11, 2019 •
edited
Loading

Hi @estroz and @joelanford,

The changes requested are done. Realy tks for your review.
Please, feel free to check if all is ok and please let me know if has anything else that we should improve here.

joelanford
joelanford approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing last set of comments.

internal/pkg/scaffold/olm-catalog/csv_updaters.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 12, 2019 •
edited
Loading

Hi @joelanford,

Thank you for your review and help on it. The latest nits were addressed.

Hi @estroz,

Could you please recheck it and let us know if you are ok with?

estroz
estroz reviewed Aug 12, 2019
View reviewed changes
...oy/olm-catalog/memcached-operator/0.0.4/memcached-operator.v0.0.4.clusterserviceversion.yaml Outdated
@@ -0,0 +1,177 @@
apiVersion: operators.coreos.com/v1alpha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in 0.0.3's CSV. We aren't updating any field content, just indentation. No need to make a new version/file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I got

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2019
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 12, 2019 •
edited
Loading

All latest nits addressed tks for the review and goods spots. 👍
c/c @joelanford @estroz

joelanford
joelanford approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @camilamacedo86. LGTM!

@estroz
Copy link
Member

estroz commented Aug 12, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2019
estroz
estroz approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@estroz
Copy link
Member

estroz commented Aug 12, 2019

/test e2e-aws-subcommand

@estroz estroz merged commit 9e1550e into operator-framework:master Aug 12, 2019
@estroz
Copy link
Member

estroz commented Aug 12, 2019

@camilamacedo86 thanks for the PR!

@camilamacedo86 camilamacedo86 deleted the ISSUE_1708 branch August 13, 2019 07:59
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 19, 2019
Closed
@jmontleon jmontleon mentioned this pull request Nov 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@estroz estroz estroz approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilamacedo86 @openshift-ci-robot @estroz @joelanford