Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: added new flag --skip-generation for operator-sdk add api #1890

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Conversation

yangzhares
Copy link
Contributor

To skip to run k8s codegen and openapi-gen to generate deepcopy and validation spec for new CRD

Description of the change:
Added new flag --skip-generation for operator-sdk add api

Motivation for the change:
To skip to run k8s codegen and openapi-gen to generate deepcopy and validation spec for new CRD

To skip to run k8s codegen and openapi-gen to generate deepcopy and validation spec for new CRD
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2019
@openshift-ci-robot
Copy link

Hi @yangzhares. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2019
@camilamacedo86 camilamacedo86 self-assigned this Sep 8, 2019
@camilamacedo86
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2019
@camilamacedo86
Copy link
Contributor

Ref: #1878

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked that it worked as expected locally
  • The change was done as suggested by @joelanford
  • The change was added in the CHANGELOG as well
  • Commits are squashed.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2019
@camilamacedo86 camilamacedo86 merged commit ac8b956 into operator-framework:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants