scaffold: printVersion includes operator's Version

[drnic]

Description of the change:

The scaffold for Operator bootstrapping now includes the Operator's version.Version.

Motivation for the change:

Currently an Operator built from scaffold does not print the Operator's version.Version

(This is my first PR; sorry if there is additional context you need, or if you're not looking for this type of PR)

[openshift-ci-robot]

Hi @drnic. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[estroz]

@drnic thanks for submitting a PR! This change is a nice-to-have.

/ok-to-test

[drnic]

I’ll investigate the CI failure soon. Sorry about that.

[drnic]

Any pro tips for debugging/fixing this?

[estroz]

/test e2e-aws-go
/test e2e-aws-ansible

[drnic]

Hurray! The simple delights of CI passing.

[camilamacedo86]

Hi @djzager,

Thank you for your contribution.

It is missing the CHANGELOG entry. Could you please add it?
Also, IMHO it would be better Operator Version instead of just Version in order to make clear from where came the version. Do not you agree? WDYT?

[camilamacedo86]

It was tested locally and all worked fine.
Asked for a few nits and add Changelog.

/lgtm
/approve

 $ operator-sdk up local 
INFO[0000] Running the operator locally.                
INFO[0000] Using namespace default.                     
{"level":"info","ts":1570560195.7755609,"logger":"cmd","msg":"Version: 0.0.1"}
{"level":"info","ts":1570560195.775807,"logger":"cmd","msg":"Go Version: go1.12.10"}
{"level":"info","ts":1570560195.775821,"logger":"cmd","msg":"Go OS/Arch: darwin/amd64"}
{"level":"info","ts":1570560195.775827,"logger":"cmd","msg":"Version of operator-sdk: v0.10.0+git"}
{"level":"info","ts":1570560195.776957,"logger":"leader","msg":"Trying to become the leader."}
{"level":"info","ts":1570560195.7769878,"logger":"leader","msg":"Skipping leader election; not running in a cluster."}

[drnic]

Fixed minor suggestions + rebased against master.

[camilamacedo86]

/lgtm
/approve

[joelanford]

LGTM once CHANGELOG is updated.

[camilamacedo86]

Hi @drnic,

It still missing the changelog entry. The commit for it maybe needs to be pushed.

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[drnic]

Sorry, I missed the request for CHANGELOG update earlier.

[camilamacedo86]

Since we have the release of 0.11.
In order, we are able to merge its required: rebase the PR with the master branch and move this entry for the UNRELEASED section. Could you help us with @drnic? Also, in order to avoid rebase conflicts I would suggest to you keep the update changelog in a another commit, is it possible?

[drnic]

@camilamacedo86 ok, done

[camilamacedo86]

HI @drnic,

I think maybe you forget to push the change. This entry needs to be moved for here.

And really tks for your contribution 🥇
iIt is very important to us.

[drnic]

Oh you released 0.11 without this PR. Sorry.

[drnic]

I kept the PR as two commits and fixed/updated your CHANGELOG update commit.

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[camilamacedo86]

/test e2e-aws-go
/test e2e-aws-ansible

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[joelanford]

My only concern here is that I'm not sure how many SDK users are aware of the version package that gets scaffolded into their projects. However, since this affects only scaffolded code that can be changed by users and only newly scaffolded projects, it isn't really a problem.

LGTM, after fixing nits in CHANGELOG.

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.