internal/pkg/scaffold/olm-catalog/csv_updaters.go: fix applying owned CRDs #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
joelanford
requested review from
camilamacedo86 and
hasbro17
and removed request for
AlexNPavel
joelanford
added
the
release-blocker
hasbro17
approved these changes
Oct 7, 2019
|
/test e2e-aws-ansible |
|
/test e2e-aws-ansible |
|
/test e2e-aws-helm |
hasbro17
pushed a commit
to hasbro17/operator-sdk
that referenced
this pull request
Oct 8, 2019
… CRDs (operator-framework#2017) * internal/pkg/scaffold/olm-catalog/csv_updaters.go: fix applying owned CRDs * CHANGELOG.md: add line for operator-framework#2017 (cherry picked from commit 5bfe311)
hasbro17
pushed a commit
to hasbro17/operator-sdk
that referenced
this pull request
Oct 9, 2019
… CRDs (operator-framework#2017) * internal/pkg/scaffold/olm-catalog/csv_updaters.go: fix applying owned CRDs * CHANGELOG.md: add line for operator-framework#2017 (cherry picked from commit 5bfe311)
hasbro17
added a commit
that referenced
this pull request
Oct 9, 2019
* *: fix gen-csv to copy CRD manifests with any name (#2015) (cherry picked from commit 5d22a11) * internal/pkg/scaffold/olm-catalog/csv_updaters.go: fix applying owned CRDs (#2017) * internal/pkg/scaffold/olm-catalog/csv_updaters.go: fix applying owned CRDs * CHANGELOG.md: add line for #2017 (cherry picked from commit 5bfe311)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR fixes an issue in
olm-catalog gen-csvwhere the CSV's owned CRDs are not properly populated from CRD manifests indeploy/crds.The current code has two issues:
--from-versionis not used), no CRDs are populated.--from-versionis used), only CRDs that are in the original version will be carried forward to the new version, even if there are new CRDs present indeploy/crdsThese issues stem from the fact that the CSV updater iterates the existing set of CRDs to build the new set. In case 1, the existing set is empty, since nothing exists, which explains why no CRDs are populated.
Motivation for the change:
Fixes the above described issue.