Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/doc: Autogen CLI Documentation #2099

Merged
merged 28 commits into from
Nov 7, 2019

Conversation

theishshah
Copy link
Member

Description of the change:

Adds make doc command to generate CLI documentation

Motivation for the change:

Reduce developer friction when making changes to the CLI

Includes sample generated documentation

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 23, 2019
jmccormick2001
jmccormick2001 previously approved these changes Oct 30, 2019
Copy link
Contributor

@jmccormick2001 jmccormick2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to build the docs on my local dev box fine. I evaluate the content but see that it
was generated. I'm assuming the generated docs will be linked from some new document
in a separate PR?

Makefile Outdated
@@ -56,6 +56,9 @@ tidy: ## Update dependencies
clean: ## Clean up the build artifacts
$(Q)rm -rf build

doc: ## Generate CLI Documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional] Could this be cli-doc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, done.

estroz
estroz previously approved these changes Nov 6, 2019
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few formatting nits, otherwise

/lgtm

hack/doc/gen_cli_doc.sh Outdated Show resolved Hide resolved
hack/doc/gen-cli-doc.go Outdated Show resolved Hide resolved
hack/doc/gen-cli-doc.go Outdated Show resolved Hide resolved
hack/doc/gen-cli-doc.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
theishshah and others added 5 commits November 6, 2019 13:47
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@theishshah theishshah changed the title [WIP] hack/doc: Autogen CLI Documentation hack/doc: Autogen CLI Documentation Nov 6, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2019
@theishshah theishshah merged commit ef10337 into operator-framework:master Nov 7, 2019
@theishshah theishshah deleted the autogen-cli-docs branch November 7, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants