Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: allow relative paths for helm charts in watches.yaml file #2287

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

joelanford
Copy link
Member

Description of the change:

  • Changes the Helm operator to support relative paths to chart directories in the watches.yaml file. If a relative paths is found, a base path will be prepended. The prefered base path comes from the HELM_CHARTS_PATH environment variable. If that is empty or not set, the operator falls back to the HOME directory, which maintains backward compatibility with existing projects.
  • Updates the Helm operator project's watches.yaml scaffold to use a relative path instead of an absolute path.

Motivation for the change:
Allowing relative paths simplifies the experience of switching between operator-sdk up local and running in-cluster.

Now local filesystem changes do not have to be made for up local to work. Previously, developers had to copy their chart to /opt/helm/helm-charts/<chart-name>, create a symlink, or change their watches.yaml temporarily to point to the absolute path of their local project (and then be forced to change it back before running operator-sdk build)

@joelanford joelanford added kind/feature Categorizes issue or PR as related to a new feature. language/helm Issue is related to a Helm operator project labels Dec 2, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 2, 2019
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Dec 2, 2019
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Dec 3, 2019
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Dec 3, 2019
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Dec 3, 2019
camilamacedo86
camilamacedo86 previously approved these changes Dec 3, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@camilamacedo86 camilamacedo86 dismissed their stale review December 3, 2019 03:22

I would like to test locally first.

@camilamacedo86 camilamacedo86 removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approved

@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@joelanford joelanford merged commit 052560a into operator-framework:master Dec 4, 2019
@joelanford joelanford deleted the helm-charts-path branch December 4, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. language/helm Issue is related to a Helm operator project lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants