cmd/operator-sdk/build: fix handling of spaces within quotes #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
dustinspecker
force-pushed
the
fix-image-build-args
branch
from
6d8048e
to
1b7b18b
Compare
| splitArgs, err := shlex.Split(bargs) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("image-build-args is not parseable (%v)", err) | ||
| } | ||
| args = append(args, splitArgs...) |
There was a problem hiding this comment.
I think we have not a test for this option.
WDYT about add it here?
There was a problem hiding this comment.
I like that idea a lot. Was wondering where a good place for a test would be.
dustinspecker
force-pushed
the
fix-image-build-args
branch
from
1b7b18b
to
cea92d5
Compare
openshift-ci-robot
added
size/XS
openshift-ci-robot
added
size/S
dustinspecker
force-pushed
the
fix-image-build-args
branch
3 times, most recently
from
f5b3c0e
to
f56f217
Compare
Before when running `operator-sdk build` with an `--image-build-arg` of something like `--label some.name="First Last"` then `operator-sdk` would invoke the builder with ["--label", "some.name=First", "Last"], when it was actually desired to be ["--label", "some.name=First Last"]. Using `shlex` handles all the appropriate parsing of spaces within quotes unlike `strings.Fields` which just splits on any spaces regardless of context like quotes. Switching to `shlex` enables `operator-sdk build` to now properly handle spaces within quotes.
dustinspecker
force-pushed
the
fix-image-build-args
branch
from
f56f217
to
0f477af
Compare
camilamacedo86
requested review from
joelanford,
jmrodri,
asmacdo,
hasbro17 and
jmccormick2001
estroz
approved these changes
Dec 11, 2019
camilamacedo86
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
The code shows fine.
Since it has a test + changelog + it is ok for @estroz
/lgtm
/approved as well 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when running
operator-sdk buildwith an--image-build-argofsomething like
--label some.name="First Last"thenoperator-sdkwould invoke the builder with ["--label", "some.name=First", "Last"],
when it was actually desired to be ["--label", "some.name=First Last"].
Using
shlexhandles all the appropriate parsing of spaces within quotesunlike
strings.Fieldswhich just splits on any spaces regardless ofcontext like quotes.
Switching to
shlexenablesoperator-sdk buildto now properly handlespaces within quotes.