pkg/helm: add overrideValues to watches.yaml (with env expansion) #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
added
kind/feature
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/M
pkg/helm/watches/watches.go
Outdated
|
|
||
| yaml "gopkg.in/yaml.v2" | ||
| "github.com/ghodss/yaml" |
There was a problem hiding this comment.
Is this a conscious change and why?
There was a problem hiding this comment.
It is. When gopkg.in/yaml.v2 unmarshals, the resulting map[string]interface{} child maps with type map[interface{}]interface{}. github.com/ghodss/yaml gets this right with map[string]interface{} all the way down.
shawn-hurley
requested changes
Dec 16, 2019
joelanford
force-pushed
the
helm-image-env
branch
from
851b990
to
1d30565
Compare
openshift-ci-robot
added
size/L
joelanford
force-pushed
the
helm-image-env
branch
from
1d30565
to
81ae668
Compare
joelanford
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
…sion), update tests and docs
joelanford
force-pushed
the
helm-image-env
branch
from
81ae668
to
cb69aae
Compare
shawn-hurley
approved these changes
Jan 3, 2020
camilamacedo86
added a commit
to operator-framework/operator-sdk-samples
that referenced
this pull request
Feb 19, 2020
* upgrade helm to use SDK 0.14.1 by: * changes applied by in roles, crd and watch by comparing the project with an empty new helm project created with 0.14.1. * the watch was changed because with it no longer equired to inform the full path. See: (operator-framework/operator-sdk#2325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds
overrideValuesfield to Helm operator's watches.yaml file, which allows an operator author to specify a values map that is merged with (and overrides) CRspecvalues.The values defined in
overrideValuescan use environment variable expansion (e.g.$MY_VARor${MY_VAR}) to use values from the environment.Motivation for the change:
In order to support disconnected scenarios and automated operand image rebuilds (e.g. to fix a CVE) it is necessary
To Do
overrideValuesoverrideValues, the container image should be built such that each environment variable is set to the chart's default value for that field.