cmd/operator-sdk: add bundle validate command
#2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
joelanford,
jmccormick2001,
hasbro17,
theishshah,
camilamacedo86,
dinhxuanvu and
exdx
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/L
camilamacedo86
approved these changes
Jan 16, 2020
exdx
reviewed
Jan 16, 2020
exdx
reviewed
Jan 16, 2020
exdx
reviewed
Jan 16, 2020
|
LGTM, just some small comments |
estroz
force-pushed
the
feature/bundle-validate-cli
branch
from
11d3dcf
to
fae504d
Compare
|
/hold Waiting on operator-framework/operator-registry#146 to update |
openshift-ci-robot
added
the
do-not-merge/hold
estroz
changed the title
bundle validate commandbundle validate command
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
joelanford
approved these changes
Jan 17, 2020
| logger := log.WithFields(log.Fields{"container-tool": c.imageBuilder}) | ||
| log.SetLevel(log.DebugLevel) | ||
| val := bundle.NewImageValidator(c.imageBuilder, logger) | ||
| if err = val.PullBundleImage(c.imageTag, dir); err != nil { |
There was a problem hiding this comment.
Does this command work if I have a bundle image on my local system and I haven't pushed it to a registry yet?
There was a problem hiding this comment.
Apparently not. I tested this command with a few images: local ones all returning the same error, while registry images were fine. I'll add a note here.
Additionally error messages can be improved in PullBundleImage, as right now the only message I'm seeing is exit status 1 @exdx @dinhxuanvu.
openshift-ci-robot
added
lgtm
|
New changes are detected. LGTM label has been removed. |
CLI wrapper for operator-registry bundle content and format validators go.mod,go.sum: pin operator-registry commit containing validation functions doc/cli: regenerate CHANGELOG.md: add bundle validate addition
estroz
force-pushed
the
feature/bundle-validate-cli
branch
from
8eee978
to
4c28290
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
bundle validatecan be run on a bundle image manually built after runningbundle build --generate-only.