Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.14.x] pkg/helm: install resources in same namespace as CR #2424

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

joelanford
Copy link
Member

Description of the change:
Backport #2414 to v0.14.x

Motivation for the change:
See #2416

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020
@joelanford joelanford changed the title v0.14.x: pkg/helm: install resources in same namespace as CR [v0.14.x] pkg/helm: install resources in same namespace as CR Jan 17, 2020
This commit fixes a bug that causes all release resources
to be created in the namespace that the operator is deployed
in, not the namespace that the CR is deployed in.
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020
@joelanford joelanford merged commit 6b4e056 into operator-framework:v0.14.x Jan 18, 2020
@joelanford joelanford deleted the backport-2414 branch January 18, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants