scorecard - add PATCH to list of methods in scorecard CR update test #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmccormick2001
requested review from
jmrodri,
joelanford,
camilamacedo86 and
estroz
openshift-ci-robot
added
the
size/XS
joelanford
approved these changes
Feb 6, 2020
| @@ -170,15 +170,16 @@ func (t *WritingIntoCRsHasEffectTest) Run(ctx context.Context) *schelpers.TestRe | |||
| if !ok { | |||
| continue | |||
| } | |||
| if method == "PUT" || method == "POST" { | |||
|
|
|||
| if method == "PUT" || method == "POST" || method == "PATCH" { | |||
There was a problem hiding this comment.
Non-blocking nit: change these to http.MethodPut, http.MethodPost, etc.
There was a problem hiding this comment.
fixed, good catch!
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
with this change, the scorecard basic test (updatecr) will add PATCH to the list of http methods checked from the proxy log, previously only PUT and POST were checked and if found would cause the scorecard test to pass.
Motivation for the change:
this issue arises when you have an operator that is NOT written with the SDK AND when you want that operator to pass the scorecard basic-test UpdateCR test. With this change, the proxy when it logs a PATCH http method, will cause the operator basic test (update cr) to detect the PATCH and pass the test.