Scorecard - add proxy port configuration setting #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
jmccormick2001
requested review from
jmrodri and
camilamacedo86
and removed request for
joelanford
fabianvf
approved these changes
Mar 10, 2020
| } | ||
| port = i | ||
| } | ||
| log.Infof("Listening on port %d.", port) |
There was a problem hiding this comment.
Super minor nit and definitely non-blocking, but to me this implies that the server is up already, when in reality it gets launched further below. There's probably not much possibility of hanging or something between here and there, but maybe we should move this log message to below where the proxy is actually started, or reword it to make it clear that we will attempt to launch the proxy on this port later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
this change adds a proxy-port configuration setting for the scorecard
Motivation for the change:
scorecard users can use a port other than the default, 8889, if they set the proxy-port configuration setting for the scorecard.