up local command: add flag operator-flags #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
reviewed
May 17, 2018
| kubernetes cluster using a kubeconfig file. | ||
| `, | ||
| Run: upLocalFunc, | ||
| } | ||
|
|
||
| upLocalCmd.Flags().StringVar(&kubeConfig, "kubeconfig", "", "The file path to kubernetes configuration file; defaults to $HOME/.kube/config") | ||
| upLocalCmd.Flags().StringVar(&passThroughFlags, "extra-flags", "", "The extra flags that your operator will need. Example: \"--namespace test\"") |
There was a problem hiding this comment.
I think we might want to make "extra-flags" more explicit such as "operator-flags"
I think change the description to:
"The flags that the operator needs. Example: \"--flag1=value1 --flag2=value2 ...\""
sounds a bit more formal to avoid your and will.
|
|
||
| return upLocalCmd | ||
| } | ||
|
|
||
| var ( | ||
| kubeConfig string | ||
| kubeConfig string | ||
| passThroughFlags string |
There was a problem hiding this comment.
suggest to use operatorFlags instead of passThroughFlags.
|
lgtm |
fanminshi
changed the title
|
One last nit, could you update the commit title to use operator-flags instead of extra-flags? |
extra-flags gives the ability to pass flags to the local operator. Fixes operator-framework#255
This was referenced May 22, 2018
m1kola
pushed a commit
to m1kola/operator-sdk
that referenced
this pull request
Jun 7, 2024
…-master Bug 2100001: Merge upstream tag v1.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator-flags gives the ability to pass flags to the local operator.
Fixes #255