Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate csv: un-deprecate --csv-channel and --default-channel #3023

Merged
merged 1 commit into from May 13, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented May 13, 2020

Description of the change:
cmd/operator-sdk/generate: remove deprecations on --csv-channel and --default-channel.

Motivation for the change: package manifests are not deprecated. See #2944.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz force-pushed the bugfix/remove-deprecations branch from cd6182e to 6822e51 Compare May 13, 2020 17:19
@estroz estroz changed the title generate csv: un-deprecate --csv-channel and --default-channel generate csv: un-deprecate --csv-channel and --default-channel May 13, 2020
@estroz estroz merged commit d2b6b1a into operator-framework:master May 13, 2020
@estroz estroz deleted the bugfix/remove-deprecations branch May 13, 2020 19:02
@estroz
Copy link
Member Author

estroz commented May 14, 2020

/cherry-pick v0.17.x

@openshift-cherrypick-robot

@estroz: new pull request created: #3044

In response to this:

/cherry-pick v0.17.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants