leader: get most recent lock owner when attempting a claim #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @asmacdo |
|
correct ... since the configmap never was refreshed |
|
who merges this / anything else I need to do ? |
|
@grosser can you add a bugfix changelog file by using this template? Thanks! |
|
done |
|
CI failure looks random ... can you fix or add a retry mechanism ? |
|
Travis seems to be having CI issues today. Restarted. |
estroz
changed the title
|
/cherry-pick v0.18.x |
|
@estroz: new pull request created: #3164 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
refresh configmap when existing leader gets killed
Motivation for the change:
non-leaders would claim that the old leader is "waiting to get evicted" when in fact the leader is healthy
reproduction: