Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: add packagemanifests subcommand for legacy project layouts #3149

Conversation

estroz
Copy link
Member

@estroz estroz commented May 29, 2020

Description of the change: generate packagemanifests subcommand for legacy project layouts. Similar implementation to the command in #3096 but no --kustomize or --manifests flags since only manifests are generated.

Motivation for the change: See #3096.

/kind feature

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 29, 2020
@estroz estroz force-pushed the feature/generate-packagemanifests-legacy branch 5 times, most recently from dc21927 to 69b666b Compare June 17, 2020 19:10
@estroz estroz marked this pull request as ready for review June 17, 2020 19:10
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2020
@estroz
Copy link
Member Author

estroz commented Jun 17, 2020

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits but LGTM.

hack/tests/subcommand-generate-csv.sh Outdated Show resolved Hide resolved
@estroz estroz force-pushed the feature/generate-packagemanifests-legacy branch from 69b666b to 04eacd3 Compare June 18, 2020 00:03
@estroz estroz merged commit ca0e78d into operator-framework:master Jun 18, 2020
@estroz estroz deleted the feature/generate-packagemanifests-legacy branch June 18, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants