Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'operator-sdk add crd' cmd #3180

Merged

Conversation

varshaprasad96
Copy link
Member

Description of the change:
Hide operator-sdk add crd command and add deprecation message.

cmd/operator-sdk/add/crd.go Outdated Show resolved Hide resolved
@varshaprasad96 varshaprasad96 force-pushed the deprecate/add-crd branch 4 times, most recently from ad99bba to ae62b1a Compare June 4, 2020 22:37
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar nits, and a changelog fragment is required.

cmd/operator-sdk/add/crd.go Outdated Show resolved Hide resolved
cmd/operator-sdk/add/crd.go Outdated Show resolved Hide resolved
cmd/operator-sdk/add/crd.go Outdated Show resolved Hide resolved
cmd/operator-sdk/add/crd.go Outdated Show resolved Hide resolved
Hide `add crd` command and add deprecation message.
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@varshaprasad96 varshaprasad96 merged commit 9ea16f0 into operator-framework:master Jun 5, 2020
@varshaprasad96 varshaprasad96 deleted the deprecate/add-crd branch June 5, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants