Use scorecard v1alpha3 #3208
Use scorecard v1alpha3 #3208
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
fabianvf
force-pushed
the
use-scorecard-v1alpha3
branch
from
9527b50
to
b87bcda
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -697,6 +697,7 @@ github.com/operator-framework/operator-sdk v0.17.0 h1:+TTrGjXa+lm7g7Cm0UtFcgOjnw | |||
| github.com/operator-framework/operator-sdk v0.17.0/go.mod h1:wmYi08aoUmtgfoUamURmssI4dkdFGNtSI1Egj+ZfBnk= | |||
internal/scorecard/alpha/run_test.go
Outdated
| mockResult.Name = "mocked test" | ||
| mockResult.Description = "mocked test description" | ||
| mockResult.State = v1alpha2.PassState | ||
| // mockResult.Description = "mocked test description" |
fabianvf
force-pushed
the
use-scorecard-v1alpha3
branch
from
b87bcda
to
2fa3abf
Compare
There was a problem hiding this comment.
the project is not building. See: https://travis-ci.org/github/operator-framework/operator-sdk/jobs/697332962#L941
| @@ -103,6 +103,7 @@ images/scorecard-test/scorecard-test | |||
| pkg/ansible/runner/testdata/valid.yaml | |||
| /bin | |||
| test/test-framework/go.sum | |||
| internal/scorecard/alpha/examples/custom-scorecard-tests/go.sum | |||
|
|
|||
| # Website | |||
| website/public/ | |||
There was a problem hiding this comment.
should we not add a fragment for that?
There was a problem hiding this comment.
I don't think so, shouldn't have any impact on the user. Fragment probably required for some other stuff htough
There was a problem hiding this comment.
is not it changing the json output? see here
There was a problem hiding this comment.
It looks like that link just takes me back to this conversation
s/ScorecardTestResult/TestResult s/ScorecardOutput/Test s/output.Results/output.Status.Results Fix errors in formatting.go s/testOutput.Results/testOutput.Status.Results Unit tests now passing Remove unused description argument Description has been removed Update scorecard alpha docs
fabianvf
force-pushed
the
use-scorecard-v1alpha3
branch
from
0cf4d59
to
94aaacf
Compare
| @@ -25,30 +25,29 @@ const ( | |||
| ) | |||
|
|
|||
| // CheckSpecTest verifies that CRs have a spec block | |||
| func CheckSpecTest(bundle *apimanifests.Bundle) scapiv1alpha2.ScorecardTestResult { | |||
| r := scapiv1alpha2.ScorecardTestResult{} | |||
| func CheckSpecTest(bundle *apimanifests.Bundle) scapiv1alpha3.TestResult { | |||
There was a problem hiding this comment.
we want with v1alpha3 for a test to be able to return multiple test results instead of just a single result as before. So instead of returning TestResult, all the tests (basic/olm) should return a TestStatus, in cases like basic/olm where only a single test result is created, you end up with a TestStatus that has Results length = 1.
|
New changes are detected. LGTM label has been removed. |
Description of the change:
We will now use the newly defined Scorecard v1alpha3 API instead of v1alpha2
Motivation for the change:
v1alpha2 has been superseded by v1alpha3