generate (new CLI): change default output dirs #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
requested review from
bharathi-tenneti,
hasbro17,
jmrodri and
joelanford
estroz
force-pushed
the
refactor/rename-generate-defaults
branch
from
2bce804
to
a1e7d15
Compare
|
/hold Blocked by #3258 |
openshift-ci-robot
added
the
do-not-merge/hold
estroz
changed the title
kustomize subcommand, change default output dirs
|
/remove-kind feature |
openshift-ci-robot
removed
the
kind/feature
estroz
force-pushed
the
refactor/rename-generate-defaults
branch
from
a1e7d15
to
87dce21
Compare
…elated files;
instead, `generate kustomize manifests` will do so.
`bundle` will write manifests/metadata to the top-level `bundle/` directory,
and `packagemanifests` will write manifests and the package manifest to
the top-level `packagemanifests/`; these are deployable files that do not
require further kustomization, so should not reside in `config/`.
*: remove `config/` prefix for generated manifests/metadata, change
`config/{bundle,packagemanifests}` to `config/manifests` in `--kustomize`
logic
estroz
force-pushed
the
refactor/rename-generate-defaults
branch
from
87dce21
to
eadf808
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
hasbro17
reviewed
Jun 18, 2020
hasbro17
reviewed
Jun 19, 2020
Comment on lines
+120
to
+121
| if c.kustomizeDir == "" { | ||
| return errors.New("--kustomize-dir must be set") |
There was a problem hiding this comment.
So --kustomize-dir seems to be a required flag now. Unless it should be defaulted to config/manifests.
Can we mark it as such, and also I didn't see it used in the example text:
$ kustomize build config/manifests | operator-sdk generate bundle --manifests --metadata --overwrite --version 0.0.1
There was a problem hiding this comment.
This flag is required but defaults to config/manifests.
There was a problem hiding this comment.
Just double checking. It is required in the sense that it can't be empty, but not required in the sense that it doesn't have to be provided on the command line?
There was a problem hiding this comment.
Correct, much like --deploy-dir in the legacy CLI.
hasbro17
reviewed
Jun 19, 2020
estroz
force-pushed
the
refactor/rename-generate-defaults
branch
from
22f054d
to
cba74f0
Compare
estroz
force-pushed
the
refactor/rename-generate-defaults
branch
from
cba74f0
to
fd0fa16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
*: remove
config/prefix for generated manifests/metadata for both bundles and package manifestsMotivation for the change:
bundleandpackagemanifestsdefault output paths are changing because generated files do not require further kustomization and so should not reside inconfig/with other kustomizeable manifests.bundlewill write manifests/metadata to the top-levelbundle/directorypackagemanifestswill write manifests and the package manifest to the top-levelpackagemanifests/directoryThis PR also leverages
generate kustomize manifests, added in #3258./cc @hasbro17 @joelanford @jmrodri @bharathi-tenneti
/kind feature