Scorecard2 kuttl image #3278
Scorecard2 kuttl image #3278
Conversation
…od completion, add SCORECARD_NAMESSPACE env var for test pods like kuttl
openshift-ci-robot
added
the
needs-rebase
…od completion, add SCORECARD_NAMESSPACE env var for test pods like kuttl
openshift-ci-robot
removed
the
needs-rebase
| @@ -32,16 +32,19 @@ ANSIBLE_BASE_IMAGE = quay.io/operator-framework/ansible-operator | |||
| HELM_BASE_IMAGE = quay.io/operator-framework/helm-operator | |||
| SCORECARD_PROXY_BASE_IMAGE = quay.io/operator-framework/scorecard-proxy | |||
| SCORECARD_TEST_BASE_IMAGE = quay.io/operator-framework/scorecard-test | |||
| SCORECARD_TEST_KUTTL_BASE_IMAGE = quay.io/operator-framework/scorecard-test-kuttl | |||
There was a problem hiding this comment.
We've got to start consolidating these image builds. We have a ton of deploy jobs on merge with master. For a follow-up.
There was a problem hiding this comment.
IMO we need have the targets to run/exec each one if we just want a specific image. However, I agree that the setup in the Travis master now has a lot of images and we could track a task to try aggregate then if it will reduce the time.
internal/plugins/golang/v2/plugin.go
Outdated
| func (Plugin) Name() string { return (kbgov2.Plugin{}).Name() } | ||
| func (Plugin) Version() plugin.Version { return (kbgov2.Plugin{}).Version() } | ||
| func (Plugin) SupportedProjectVersions() []string { return (kbgov2.Plugin{}).SupportedProjectVersions() } | ||
| func (Plugin) Name() string { |
There was a problem hiding this comment.
I assume these gofmt changes are a result of using go v1.14. These changes should be made separately, and we should consider bumping the SDK's go version to v1.14.
There was a problem hiding this comment.
I switched this back to the original format. Not sure but it must have been my local dev setup.
|
/retest |
|
|
||
| image-push-scorecard-test-kuttl-multiarch: | ||
| ./hack/image/push-manifest-list.sh $(SCORECARD_TEST_KUTTL_IMAGE) ${SCORECARD_TEST_KUTTL_ARCHES} | ||
|
|
There was a problem hiding this comment.
is not missing call it in the travis? See: https://github.com/operator-framework/operator-sdk/blob/master/.travis.yml#L319-L323
Also, have we already the images repo configured and etc ?
There was a problem hiding this comment.
repos are ready for this but I was going to do the travis update in a separate PR.
There was a problem hiding this comment.
It shows for me:
/lgtm /approve
PS.: Travis update for master build/push the images will be done in a follow-up. see https://github.com/operator-framework/operator-sdk/pull/3278/files#r449917308
| @@ -156,7 +159,7 @@ build/%.asc: ## Create release signatures for operator-sdk release binaries | |||
|
|
|||
| image: image-build image-push ## Build and push all images | |||
|
|
|||
| image-build: image-build-ansible image-build-helm image-build-scorecard-proxy image-build-scorecard-test ## Build all images | |||
| image-build: image-build-ansible image-build-helm image-build-scorecard-proxy image-build-scorecard-test image-build-scorecard-test-kuttl## Build all images | |||
There was a problem hiding this comment.
nit: should be a space before the ## Build all images.
There was a problem hiding this comment.
thanks, will fix that in an upcoming PR to update the SHA image of the kuttl base image.
Description of the change:
this PR adds the scorecard-test-kuttl image
this image is to support kuttl integration into scorecard2 allowing scorecard users to
add and execute kuttl tests via scorecard2. Follow on PRs will modify the travis
configuration to build this image as part of a release...a follow on PR will also add
user facing web docs regarding kuttl tests.
Motivation for the change:
part of the overall scorecard2 implementation.