[olm-cmd] Add "version" flag to olm commands #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshaprasad96
force-pushed
the
olm-command/test
branch
from
4c46e7f
to
ddf2941
Compare
varshaprasad96
force-pushed
the
olm-command/test
branch
from
ddf2941
to
68cd278
Compare
estroz
suggested changes
Jun 23, 2020
varshaprasad96
force-pushed
the
olm-command/test
branch
from
68cd278
to
1d35a1a
Compare
estroz
reviewed
Jun 24, 2020
| @@ -19,6 +19,7 @@ operator-sdk olm status [flags] | |||
| -h, --help help for status | |||
| --olm-namespace string namespace where OLM is installed (default "olm") | |||
There was a problem hiding this comment.
Follow-up: add --olm-namespace to uninstall
This PR adds "--version" flag to olm commands, thereby enabling users to specify the version of olm to uninstall or look for while fetching the status of its resources.
varshaprasad96
force-pushed
the
olm-command/test
branch
from
1d35a1a
to
ec7a2cb
Compare
varshaprasad96
commented
Jun 24, 2020
|
|
||
| # Uninstall should fail with OLM not installed | ||
| commandoutput=$(operator-sdk olm uninstall 2>&1 || true) | ||
| echo $commandoutput | grep -F "Failed to uninstall OLM: no existing installation found" | ||
| echo $commandoutput | grep -F "Failed to uninstall OLM" |
There was a problem hiding this comment.
Since we are logging the reason of failure in error too, checking just whether installation/fetching status failed or not (for CI to pass).
estroz
reviewed
Jun 24, 2020
varshaprasad96
force-pushed
the
olm-command/test
branch
from
ec7a2cb
to
19f665c
Compare
varshaprasad96
force-pushed
the
olm-command/test
branch
from
19f665c
to
12c8bb4
Compare
|
New changes are detected. LGTM label has been removed. |
varshaprasad96
force-pushed
the
olm-command/test
branch
from
12c8bb4
to
2f7b661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR adds "--version" flag to olm sub-commands, thereby enabling
users to specify the version of olm to uninstall or look up for
while fetching the status of its resources.
Motivation for the change:
Allow users to override the version of OLM inferred from packageservers's CSV
Closes : #3095