Modify default value of overwrite flag in generate-bundle cmd #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshaprasad96
requested review from
estroz
and removed request for
rashmigottipati and
hasbro17
jmccormick2001
approved these changes
Jun 23, 2020
| @@ -210,6 +210,6 @@ func (c *bundleCmd) addCommonFlagsTo(fs *pflag.FlagSet) { | |||
| fs.StringVar(&c.crdsDir, "crds-dir", "", "Root directory for CustomResoureDefinition manifests") | |||
| fs.StringVar(&c.channels, "channels", "alpha", "A comma-separated list of channels the bundle belongs to") | |||
| fs.StringVar(&c.defaultChannel, "default-channel", "", "The default channel for the bundle") | |||
| fs.BoolVar(&c.overwrite, "overwrite", false, "Overwrite the bundle's metadata and Dockerfile if they exist") | |||
| fs.BoolVar(&c.overwrite, "overwrite", true, "Overwrite the bundle's metadata and Dockerfile if they exist") | |||
| fs.BoolVarP(&c.quiet, "quiet", "q", false, "Run in quiet mode") | |||
| } | |||
varshaprasad96
force-pushed
the
gen-bundle/overwrite
branch
from
26ebe23
to
f75dce7
Compare
With this PR, "generate bundle" command by default will overwrite metadata files if already present.
varshaprasad96
force-pushed
the
gen-bundle/overwrite
branch
from
f75dce7
to
3ab4428
Compare
|
@camilamacedo86 Added changelog fragment. Please have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
With this PR, "generate bundle" command by default will overwrite
metadata files if already present.