Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: version upgrade guide: add more details for 0.11, 0.14, 0.16 #3307

Merged

Conversation

bhavin192
Copy link
Contributor

Description of the change:

Motivation for the change:
Closes #3213

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. Otherwise, I am ok with.
tks for your collab 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
- 0.11.x: sigs.k8s.io/controller-tools@v0.2.0 no longer has the
  package sigs.k8s.io/controller-tools/pkg/crd/generator
- https://github.com/kubernetes-sigs/controller-tools/tree/v0.2.0/pkg/crd
- 0.14.x: add details about the new function addMetrics()
- 0.16.x: add details about multiple namespace support

Co-authored-by: Camila Macedo <camilamacedo86@gmail.com>
Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
@bhavin192
Copy link
Contributor Author

@camilamacedo86 I have made the changes suggested by you.

@camilamacedo86
Copy link
Contributor

Hi @bhavin192,

We need + 1 ok before merge. @asmacdo @fabianvf @jmccormick2001 @jmrodri wdyt? Are you ok with these changes as well?

@camilamacedo86 camilamacedo86 merged commit 68b2609 into operator-framework:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating from 0.10.x to 0.17.1
4 participants