Migration subcommand deprecation message added #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venkat19967
force-pushed
the
deprecate_migrate
branch
from
9d64524
to
baeeeb6
Compare
| migration: | ||
| header: The migrate subcommand has been deprecated | ||
| body: > | ||
| ```operator-sdk migrate``` has been deprecated |
There was a problem hiding this comment.
Please add a new line here. Also, you would have to run make generate and commit the changes, it would update the cli-docs for this command.
| - description: > | ||
| The migrate sub-command is deprecated | ||
| kind: deprecation | ||
| breaking: true |
There was a problem hiding this comment.
Not sure if deprecation can be a breaking change. I think this should be false.
estroz
reviewed
Jul 1, 2020
Comment on lines
6
to
9
| migration: | ||
| header: The migrate subcommand has been deprecated | ||
| body: > | ||
| ```operator-sdk migrate``` has been deprecated |
There was a problem hiding this comment.
Suggested change
| migration: | |
| header: The migrate subcommand has been deprecated | |
| body: > | |
| ```operator-sdk migrate``` has been deprecated |
estroz
reviewed
Jul 1, 2020
cmd/operator-sdk/migrate/cmd.go
Outdated
| @@ -41,7 +41,8 @@ func NewCmd() *cobra.Command { | |||
| Short: "Adds source code to an operator", | |||
| Long: `operator-sdk migrate adds a main.go source file and any associated source files` + | |||
| `for an operator that is not of the "go" type.`, | |||
| RunE: migrateRun, | |||
| RunE: migrateRun, | |||
| Deprecated: "The migrate sub-command is deprecated", | |||
There was a problem hiding this comment.
Suggested change
| Deprecated: "The migrate sub-command is deprecated", | |
| Deprecated: "and will be removed by the operator-sdk v1.0.0 release", |
Venkat19967
force-pushed
the
deprecate_migrate
branch
from
4391603
to
9ea94b0
Compare
fabianvf
approved these changes
Jul 2, 2020
estroz
reviewed
Jul 2, 2020
cmd/operator-sdk/migrate/cmd.go
Outdated
| @@ -41,7 +41,8 @@ func NewCmd() *cobra.Command { | |||
| Short: "Adds source code to an operator", | |||
| Long: `operator-sdk migrate adds a main.go source file and any associated source files` + | |||
| `for an operator that is not of the "go" type.`, | |||
| RunE: migrateRun, | |||
| RunE: migrateRun, | |||
| Deprecated: "and will be removed soon", | |||
There was a problem hiding this comment.
Suggested change
| Deprecated: "and will be removed soon", | |
| Deprecated: "and will be removed prior to operator-sdk v1.0.0", |
Venkat19967
force-pushed
the
deprecate_migrate
branch
from
9ea94b0
to
57f89e8
Compare
camilamacedo86
pushed a commit
to camilamacedo86/operator-sdk
that referenced
this pull request
Jul 3, 2020
* Migration subcommand deprecation message added * Generated the docs and modified changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
OSDK-1312
Notifies the user about the deprecation of the migration sub-command
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs