Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli (legacy): deprecate generate csv #3322

Merged

Conversation

estroz
Copy link
Member

@estroz estroz commented Jun 30, 2020

Description of the change:

  • cmd/operator-sdk/generate/csv.go: add deprecation notice

Motivation for the change: users should be using generate <bundle|packagemanifests> instead.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz estroz changed the title cli (legacy): deprecate 'generate csv' cli (legacy): deprecate generate csv Jun 30, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@estroz
Copy link
Member Author

estroz commented Jul 1, 2020

Blocked by #3320

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@camilamacedo86
Copy link
Contributor

@estroz,

It is missing run make generate to update the CLI doc.

@estroz estroz force-pushed the chore/deprecate-generate-csv branch from 934e478 to 3967ecf Compare July 8, 2020 15:47
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@estroz estroz added this to the v0.19.0 milestone Jul 8, 2020
@estroz
Copy link
Member Author

estroz commented Jul 8, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@estroz estroz merged commit b8862df into operator-framework:master Jul 8, 2020
@estroz estroz deleted the chore/deprecate-generate-csv branch July 8, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants