Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli (legacy): deprecate bundle create #3323

Merged
merged 1 commit into from
Jul 8, 2020
Merged

cli (legacy): deprecate bundle create #3323

merged 1 commit into from
Jul 8, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jun 30, 2020

Description of the change:

  • cmd/operator-sdk/bundle/create.go: add deprecation notice

Motivation for the change: users should be using generate bundle and docker build -f bundle.Dockerfile instead.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz estroz changed the title cli (legacy): deprecate 'bundle create' cli (legacy): deprecate bundle create Jun 30, 2020
hasbro17
hasbro17 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz
Copy link
Member Author

estroz commented Jul 1, 2020

Blocked by #3320

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
camilamacedo86
camilamacedo86 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@camilamacedo86
Copy link
Contributor

@estroz,

It is missing run make generate to update the CLI doc.

@estroz estroz force-pushed the chore/deprecate-bundle-create branch from c0c80ab to 8feaec6 Compare July 8, 2020 15:49
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@estroz estroz force-pushed the chore/deprecate-bundle-create branch from 8feaec6 to 6f7cd0e Compare July 8, 2020 15:53
@estroz estroz added this to the v0.19.0 milestone Jul 8, 2020
@estroz estroz force-pushed the chore/deprecate-bundle-create branch from 6f7cd0e to 5dce94b Compare July 8, 2020 16:53
@estroz
Copy link
Member Author

estroz commented Jul 8, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@estroz estroz merged commit f989726 into operator-framework:master Jul 8, 2020
@estroz estroz deleted the chore/deprecate-bundle-create branch July 8, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

Labels
None yet
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estroz @camilamacedo86 @openshift-ci-robot @hasbro17