-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slight update to migration documentation #3783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
👍 tks for the contribution
In order to help others perform the review.
- The changes here are just with spaces
- Just 2 sentences have small changes which make them better (line 105, 198)
website/content/en/docs/building-operators/golang/project_migration_guide.md
Outdated
Show resolved
Hide resolved
HI @OchiengEd, Really tks for your contribution. could you please address the comment #3783 (comment) and get it rebased with the master for we are able to merge this one? |
1a385e4
to
0c76b9b
Compare
New changes are detected. LGTM label has been removed. |
@camilamacedo86 let me know if you need any further changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit otherwise lgtm
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
7b372d7
to
35cec48
Compare
Signed-off-by: Edmund Ochieng ochienged@gmail.com
Description of the change:
A couple of sentences were re-written while maintaining the intended meaning
Motivation for the change:
To clarify instructions in the instructions on migrating an existing operator to the new Operator SDK v1.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs