Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight update to migration documentation #3783

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

OchiengEd
Copy link
Contributor

@OchiengEd OchiengEd commented Aug 24, 2020

Signed-off-by: Edmund Ochieng ochienged@gmail.com

Description of the change:

A couple of sentences were re-written while maintaining the intended meaning

Motivation for the change:

To clarify instructions in the instructions on migrating an existing operator to the new Operator SDK v1.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

👍 tks for the contribution

In order to help others perform the review.

  • The changes here are just with spaces
  • Just 2 sentences have small changes which make them better (line 105, 198)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2020
@camilamacedo86
Copy link
Contributor

HI @OchiengEd,

Really tks for your contribution. could you please address the comment #3783 (comment) and get it rebased with the master for we are able to merge this one?

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2020
@OchiengEd
Copy link
Contributor Author

@camilamacedo86 let me know if you need any further changes.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise lgtm

@estroz estroz merged commit 3018140 into operator-framework:master Oct 21, 2020
@OchiengEd OchiengEd deleted the migration_fix branch October 11, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants