cleanup: delete catsrc and operatorgroup even if subscription is not found #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
reviewed
Oct 23, 2020
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
|
/cherry-pick v1.1.x |
|
@joelanford: new pull request created: #4103 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Updates the
operator-sdk cleanupsubcommand to cleanup the catalog source and operator group even when a subscription for the operator does not exist.Motivation for the change:
In the event that a user runs
operator-sdk runand an error occurs after the operator group and catalog source are created, but before a subscription is created, the operator group and catalog source must be manually cleaned up before retrying theoperator-sdk runcommand.In 1.1.0, the
operator-sdk cleanupcommand will not cleanup the operator group and catalog source in this scenario.This PR updates the
operator-sdk cleanupcommand so that even when a subscription does not exist, it looks for the expected catalog source and operator group, and deletes them if they exist.Closes #4085
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)Add or update relevant sections of the docs website inwebsite/content/en/docs