internal/plugins/helm: scaffold finalizers subresource permission for created APIs #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
reviewed
Oct 26, 2020
joelanford
force-pushed
the
fix-helm-finalizers-permissions
branch
from
195548b
to
13b51a4
Compare
joelanford
force-pushed
the
fix-helm-finalizers-permissions
branch
from
13b51a4
to
435d080
Compare
|
/cherry-pick v1.1.x |
|
@joelanford: new pull request created: #4117 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jmrodri
added a commit
to jmrodri/ocp-release-operator-sdk
that referenced
this pull request
Dec 16, 2020
The finalizers were fixed in upstream PR #4105 operator-framework/operator-sdk#4105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add
<resource>/finalizerssubresource RBAC permission for Helm operator APIsMotivation for the change:
Closes #3767
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs