Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump operator-framework/api to v0.3.20 #4109

Merged
merged 2 commits into from Oct 29, 2020
Merged

Bump operator-framework/api to v0.3.20 #4109

merged 2 commits into from Oct 29, 2020

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Oct 26, 2020 •
edited

Description of the change:
Bump operator-framework/api to v0.3.20

Closes: #4104

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz
Copy link
Member

estroz commented Oct 26, 2020

Closes #4104

joelanford
joelanford reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a good candidate for an update to the website docs and/or the CLI docs.

We should probably tell users about the environment variable and file format that for extra categories that this version adds to the bundle validate command.

changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
@varshaprasad96 varshaprasad96 changed the title Bump operator-framework/api to v0.3.18 Bump operator-framework/api to v0.3.20 Oct 27, 2020
@varshaprasad96 varshaprasad96 force-pushed the upgrade-api-version branch 2 times, most recently from 6c5a77a to a6975dc Compare October 28, 2020 17:24
estroz
estroz suggested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only be listing changes relevant to our users in changelog fragments, and only providing migration guides when there's actually a starting point to migrate from.

changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
estroz
estroz approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after suggested fix

changelog/fragments/upgrade-operator-framework-api.yaml Outdated Show resolved Hide resolved
joelanford
joelanford approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@varshaprasad96 varshaprasad96 merged commit 299dad4 into operator-framework:master Oct 29, 2020
@varshaprasad96 varshaprasad96 deleted the upgrade-api-version branch October 29, 2020 16:28
@varshaprasad96 varshaprasad96 mentioned this pull request Oct 30, 2020
Merged
2 tasks
camilamacedo86 pushed a commit that referenced this pull request Oct 31, 2020
@varshaprasad96
docs/olm-integration/generation.md: add optional validator operatorhu…
9e99cad 
…b docs (#4150)

Description of the change:
Add doc on validation of custom categories

Motivation for the change:
Follow up of #4109
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
@varshaprasad96
docs/olm-integration/generation.md: add optional validator operatorhu…
98dd795 
…b docs (operator-framework#4150)

Description of the change:
Add doc on validation of custom categories

Motivation for the change:
Follow up of operator-framework#4109


Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@joelanford joelanford joelanford approved these changes

@estroz estroz estroz approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@joelanford joelanford

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump operator-sdk to use operator-framework/api v0.3.18
5 participants
@varshaprasad96 @estroz @joelanford @camilamacedo86 @openshift-ci-robot