operator-sdk/internal/generate: fix CSV path segments for multi-field structs #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
joelanford
force-pushed
the
fix/csv-generate-path-segments
branch
from
41b3f49
to
04c0136
Compare
joelanford
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
reviewed
Nov 2, 2020
internal/generate/clusterserviceversion/bases/definitions/ast.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
camilamacedo86
approved these changes
Nov 2, 2020
|
@camilamacedo86 👍 to adding some spec and/or status descriptor markers to our samples, especially if we don't have to make any other major changes in the samples to support adding them. Can you make another issue to track this? |
|
/cherry-pick v1.1.x |
|
@joelanford: new pull request created: #4168 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
… structs (operator-framework#4166) Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Fixes a bug that causes path segments to inadvertently re-use memory from other path segments, causing
specDescriptorsandstatusDescriptorsfields to end up with incorrect paths.Motivation for the change:
Fix bug = good :)
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs