Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1921727: Bundle validate should not fail because of warnings. #4449

Merged
merged 1 commit into from Jan 29, 2021
Merged

Bug 1921727: Bundle validate should not fail because of warnings. #4449

merged 1 commit into from Jan 29, 2021

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Jan 28, 2021 •
edited

Description of the change:
Bumped to operator-framework/api.

Motivation for the change:
Bundle validate with optional validators would fail if there was a warning during the validation instead of passing but listing out the warning.

$ build/operator-sdk bundle validate --select-optional name=operatorhub registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-clusterresourceoverride-operator-bundle:v4.6.0.202101230113.p0-1
...
ERRO[0001] Error: Value : (clusterresourceoverride-operator.4.6.0-202101230113.p0) Warning: Value : csv.Spec.Icon not specified

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@jmrodri
Copy link
Member Author

jmrodri commented Jan 28, 2021

/hold needs changelog

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2021
@jmrodri
Copy link
Member Author

jmrodri commented Jan 28, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2021
@jmrodri jmrodri requested review from estroz and varshaprasad96 and removed request for fabianvf January 28, 2021 21:38
gallettilance
gallettilance approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021
varshaprasad96
varshaprasad96 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri mentioned this pull request Jan 29, 2021
Closed
@jmrodri
Bug 1921727: Bundle validate should not fail because of warnings.
be0c230 
Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
camilamacedo86
camilamacedo86 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@camilamacedo86
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@jmrodri jmrodri merged commit 36f1fe5 into operator-framework:master Jan 29, 2021
estroz pushed a commit to estroz/operator-sdk that referenced this pull request Feb 1, 2021
@jmrodri @estroz
Bug 1921727: Bundle validate should not fail because of warnings. (op…
76287ea 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@estroz estroz mentioned this pull request Feb 1, 2021
Merged
estroz pushed a commit that referenced this pull request Feb 1, 2021
@jmrodri
[v1.3.x] Bug 1921727: Bundle validate should not fail because of warn…
f340790 
…ings. (#4449) (#4458)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>

Co-authored-by: Jesus Rodriguez <jesusr@redhat.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
@jmrodri @reinvantveer
Bug 1921727: Bundle validate should not fail because of warnings. (op…
cbfeee4 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
@jmrodri @reinvantveer
Bug 1921727: Bundle validate should not fail because of warnings. (op…
0da6b67 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
@jmrodri
Bug 1921727: Bundle validate should not fail because of warnings. (op…
6d392e4 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
@jmrodri
Bug 1921727: Bundle validate should not fail because of warnings. (op…
4fd6c5d 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
@jmrodri
Bug 1921727: Bundle validate should not fail because of warnings. (op…
e5dec08 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this pull request Feb 5, 2021
@jmrodri @rearl-scwx
Bug 1921727: Bundle validate should not fail because of warnings. (op…
ca4d281 
…erator-framework#4449)

Bumped to operator-framework/api.

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>Signed-off-by: rearl <rearl@secureworks.com>
@jmrodri jmrodri deleted the bug1921727 branch January 30, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@gallettilance gallettilance gallettilance approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@estroz estroz Awaiting requested review from estroz

Assignees

@camilamacedo86 camilamacedo86

@gallettilance gallettilance

@varshaprasad96 varshaprasad96

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmrodri @camilamacedo86 @gallettilance @varshaprasad96 @openshift-ci-robot