fix swapped liveness/readiness http paths. (#4541) #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozzone
force-pushed
the
issue-4541-probe
branch
from
5ea94cc
to
c07742d
Compare
flozzone
force-pushed
the
issue-4541-probe
branch
2 times, most recently
from
d27c46d
to
886c32e
Compare
|
You @estroz also cleared something up for me, thanks :) |
* created changelog fragment * fixed scaffold template for the manager resource (ansible/helm) * fixed testdata (ansible/helm) Signed-off-by: Florin Hillebrand <flozzone@gmail.com>
flozzone
force-pushed
the
issue-4541-probe
branch
from
fef126b
to
7b6f984
Compare
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 20, 2021
…perator-framework#4546) * fixed scaffold template for the manager resource (ansible/helm) Signed-off-by: Florin Hillebrand <flozzone@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 28, 2021
…perator-framework#4546) * fixed scaffold template for the manager resource (ansible/helm) Signed-off-by: Florin Hillebrand <flozzone@gmail.com> Signed-off-by: reinvantveer <reinvantveer@gmail.com>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 28, 2021
…perator-framework#4546) * fixed scaffold template for the manager resource (ansible/helm) Signed-off-by: Florin Hillebrand <flozzone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florin Hillebrand flozzone@gmail.com
Description of the change:
Fix wrong HTTP paths of the livenessProbe and readinessProbe in the scaffold templates and testdata.
Motivation for the change:
livenessProbe and readinessProbe were swapped in templates but are correctly documented in upgrade guide.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs