New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(manifests/v2) add support for webhooks by default and docs #4623
(manifests/v2) add support for webhooks by default and docs #4623
Conversation
Still need to update docs and add a changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we are just missing some nits to get this merged:
- We need to provide the changelog which also will be useful for those who face this problem.
- Would be nice to add the manual steps to fix that in the FAQ as well. Do we have them already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
/hold It is true. It is missing the changelog and docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6a234ae
to
9adf23f
Compare
New changes are detected. LGTM label has been removed. |
/hold cancel |
9adf23f
to
bbfcb01
Compare
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
bbfcb01
to
a9048aa
Compare
Description of the change:
config/manifests/kustomization.yaml
that contains a patch to remove thecert
volume and mount from the default manager configuration.Motivation for the change: no kustomize helpers are created to enable webhooks by default. This is considered a bug since the CSV generator supports webhooks (see #4244).
Closes #4240
Closes #4244
Closes #4439
/kind bug
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs