Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate kustomize manifests: skip parsing definitions on a non-existent API root dir #4624

Conversation

estroz
Copy link
Member

@estroz estroz commented Mar 9, 2021

Description of the change:

  • internal/generate/clusterserviceversion/bases/definitions: skip on a non-existent API root dir

Motivation for the change: bugfix

/kind bug

Checklist

If the pull request includes user-facing changes, extra documentation is required:

…non-existent API root dir

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2021
@estroz estroz temporarily deployed to deploy March 9, 2021 23:27 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 23:27 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 23:27 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 23:27 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 23:27 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 23:27 Inactive
@estroz estroz merged commit 4934838 into operator-framework:master Mar 10, 2021
@estroz estroz deleted the bugfix/skip-nonexistent-apis-dirs-bundle branch March 10, 2021 00:16
@estroz

This comment has been minimized.

@estroz
Copy link
Member Author

estroz commented Mar 10, 2021

/cherry-pick v1.4.x

@openshift-cherrypick-robot

@estroz: cannot checkout v1.4.3: error checking out v1.4.3: exit status 1. output: error: pathspec 'v1.4.3' did not match any file(s) known to git

In response to this:

/cherry-pick v1.4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-cherrypick-robot

@estroz: cannot checkout v1.4.3: error checking out v1.4.3: exit status 1. output: error: pathspec 'v1.4.3' did not match any file(s) known to git

In response to this:

/cherry-pick v1.4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@estroz: new pull request created: #4625

In response to this:

/cherry-pick v1.4.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
…stent API root dir (operator-framework#4624)

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
…stent API root dir (operator-framework#4624)

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants