fix: trim quotes in interactive input #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trims quotes (single quotes, double quotes, back quotes) from interactively added strings. Closes operator-framework#5499 Signed-off-by: Ryo Imai <iryo@jp.ibm.com>
ima1mai
force-pushed
the
trim-quotes-interactive-input
branch
from
3015613
to
cbe3b59
Compare
|
/lgtm |
jberkhahn
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5499
Signed-off-by: Ryo Imai iryo@jp.ibm.com
Description of the change:
This PR changes the handling of interactive input string to trim quotes (double quotes, single quotes, back quotes) to fix #5499 . The functions depending on the changed function are only used for generating bundle CSV base manifests first time. So, I assume the impact by this change is limited.
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs