Fix related image environment variable discovery #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
joelanford
reviewed
Apr 7, 2022
openshift-ci
bot
added
the
needs-rebase
ryantking
force-pushed
the
bug/GH5574-custom-manager-name
branch
from
66e204f
to
dc99a42
Compare
openshift-ci
bot
removed
the
needs-rebase
ryantking
changed the title
ryantking
force-pushed
the
bug/GH5574-custom-manager-name
branch
2 times, most recently
from
8162309
to
55dfa37
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ryantking
force-pushed
the
bug/GH5574-custom-manager-name
branch
2 times, most recently
from
b916f3d
to
0b1e41c
Compare
|
/lgtm |
ryantking
force-pushed
the
bug/GH5574-custom-manager-name
branch
from
3015115
to
13001fc
Compare
|
/lgtm |
|
@ryantking crap, I think this needs a changelog. |
The related image discovery feature currently only reads environment variables from the manager container. This was causing an error when the deployment labels or container name that was expected were not present. This fixes that by collecting related images from all containers across all deployments. This change also enables users to use related images in other containers since related images from everywhere will be considered. Signed-off-by: Ryan King <ryking@redhat.com>
ryantking
force-pushed
the
bug/GH5574-custom-manager-name
branch
from
13001fc
to
58e91a5
Compare
|
/lgtm |
|
/cherry-pick v1.19.x |
|
@ryantking: new pull request created: #5656 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
VenkatRamaraju
pushed a commit
to VenkatRamaraju/operator-sdk
that referenced
this pull request
May 18, 2022
…5639) The related image discovery feature currently only reads environment variables from the manager container. This was causing an error when the deployment labels or container name that was expected were not present. This fixes that by collecting related images from all containers across all deployments. This change also enables users to use related images in other containers since related images from everywhere will be considered. Signed-off-by: Ryan King <ryking@redhat.com> Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju
pushed a commit
to VenkatRamaraju/operator-sdk
that referenced
this pull request
May 18, 2022
…amework#5639)" This reverts commit 2f9f680.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related image discovery feature currently only reads environment
variables from the manager container. This was causing an error when the
deployment labels or container name that was expected were not present.
This fixes that by collecting related images from all containers across
all deployments.
This change also enables users to use related images in other containers
since related images from everywhere will be considered.
Signed-off-by: Ryan King ryking@redhat.com