Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy server port customization for Ansible #5669

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

VenkatRamaraju
Copy link
Contributor

Motivation for the change:
Close #5642

Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2022
@@ -0,0 +1,9 @@
entries:
- description: >
For ansible-based operators, this feature adds a proxy-port flag that allows specification of the proxy server port.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For ansible-based operators, this feature adds a proxy-port flag that allows specification of the proxy server port.
For ansible-based operators, proxy server port can be changed from with the new `proxy-port`, which still defaults to 8888.

Just a little wordsmithing

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2022

New changes are detected. LGTM label has been removed.

Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
@VenkatRamaraju VenkatRamaraju merged commit 036788a into operator-framework:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible operator-sdk: allow customization of proxy-server port
3 participants