Fix ansible-operator finalizer concurrency issue #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ansible-based operators, this change fixes an issue that caused finalizers to fail to run if the watched resource (CR) is deleted during reconciliation. Fixes operator-framework#4909 Signed-off-by: Austin Macdonald <austin@redhat.com>
asmacdo
force-pushed
the
4909-fix-ansible-finalizer-race
branch
from
ff4991c
to
5d3b1c3
Compare
Signed-off-by: Austin Macdonald <austin@redhat.com>
Signed-off-by: Austin Macdonald <austin@redhat.com>
jmrodri
approved these changes
Apr 27, 2022
| @@ -0,0 +1,58 @@ | |||
| --- | |||
| # TODO(asmacdo) this should be the only task. the other is getting magiced in | |||
| - name: Create the test.example.com/v1alpha1.FinalizerConcurrencyTest | |||
There was a problem hiding this comment.
is there a reason the file is finalizerconcurrencytest_test? vs finalizerconcurrency_test?
There was a problem hiding this comment.
Yes, but its not a good one. The testdata generation takes the Kind name "FinalizerConcurrenctTest" and automagically creates a verify task finalizerconcurrencytest_test. Rather than delete that and put mine in place, I just clobbered it.
openshift-ci
bot
added
lgtm
asmacdo
force-pushed
the
4909-fix-ansible-finalizer-race
branch
from
6143ae2
to
518595e
Compare
Signed-off-by: Austin Macdonald <austin@redhat.com>
asmacdo
force-pushed
the
4909-fix-ansible-finalizer-race
branch
from
518595e
to
18936db
Compare
asmacdo
commented
Apr 28, 2022
| @@ -156,10 +156,16 @@ e2e_targets := test-e2e $(e2e_tests) | |||
| export KIND_CLUSTER := osdk-test | |||
|
|
|||
| KUBEBUILDER_ASSETS = $(PWD)/$(shell go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest && $(shell go env GOPATH)/bin/setup-envtest use $(ENVTEST_K8S_VERSION) --bin-dir tools/bin/ -p path) | |||
| test-e2e-setup: build | |||
| test-e2e-setup:: build dev-install cluster-create | |||
There was a problem hiding this comment.
@ryantking Since you just changed this thought you might want to have a look. After digging in, the memcached-molecule test needs to create its own cluster, so I had to separate the make targets.
Signed-off-by: Austin Macdonald <austin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ansible-based operators, this change fixes an issue that caused
finalizers to fail to run if the watched resource (CR) is deleted during
reconciliation.
Fixes #4909
Signed-off-by: Austin Macdonald austin@redhat.com
Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs