update olm bindata #5684
Merged
update olm bindata #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operator-sdk was behind on a few OLM versions. updated the supported versions and bindata. resolves operator-framework#5680 Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
|
Does this need a changelog update? |
|
Also, this updates to use the 3 latest minor version releases (0.18.3, 0.19.1, 0.20.0). Do we need to instead update it to use the 3 latest releases (0.19.0, 0.19.1, 0.20.0)? |
|
/cc @varshaprasad96 |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
There was a problem hiding this comment.
@everettraven Thanks for the PR! Yes, let's modify it to support the latest 3 versions (0.19.0, 0.19.1, 0.20.0). Also, you may have to update the available olm versions here:
for the e2e integration test suite to pass.
|
Yes, let's add changelog too. |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
varshaprasad96
approved these changes
Apr 27, 2022
| @@ -92,7 +92,7 @@ By project type (replace `${IMAGE_VERSION}` with base image version in your proj | |||
|
|
|||
| Operator SDK officially supports the latest 3 versions of OLM present at the time of a given Operator SDK release. These versions of OLM manifests are packaged with the SDK binary in the form of `bindata` to support low-latency installations of OLM with [`operator-sdk olm install`][olm-install-cmd]. Any other version installed with this command may work but is not tested nor officially supported. | |||
|
|
|||
| Currently, the officially supported OLM Versions are: 0.16.1, 0.17.0 and 0.18.2. | |||
| Currently, the officially supported OLM Versions are: 0.19.0, 0.19.1, and 0.20.0 | |||
There was a problem hiding this comment.
Just nit:
Suggested change
| Currently, the officially supported OLM Versions are: 0.19.0, 0.19.1, and 0.20.0 | |
| Currently, the officially supported OLM Versions are: 0.19.0, 0.19.1, and 0.20.0. |
jmrodri
reviewed
Apr 27, 2022
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
operator-sdk was behind on a few OLM versions. updated the supported versions and bindata.
Motivation for the change:
resolves #5680
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs