Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDK-2303: Scorecard testOutput is tightly coupled with storage mountPath #5714

Merged
merged 1 commit into from Jul 13, 2022
Merged

OSDK-2303: Scorecard testOutput is tightly coupled with storage mountPath #5714

merged 1 commit into from Jul 13, 2022

Conversation

apodhrad
Copy link
Contributor

Signed-off-by: Andrej Podhradsky apodhrad@redhat.com

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@rashmigottipati
Copy link
Member

/cc @theishshah

@openshift-ci openshift-ci bot requested a review from theishshah May 4, 2022 16:59
@jmrodri
Copy link
Member

jmrodri commented May 13, 2022

@apodhrad sorry for the late review. Because you changed the flag, that means the auto-generated CLI docs need to get updated. So if you run make generate this should update this file: website/content/en/docs/cli/operator-sdk_scorecard.md

@apodhrad
Copy link
Contributor Author

@jmrodri thx, I will do that asap

@apodhrad
Copy link
Contributor Author

Hi @jmrodri I don't know why 6 checks are still waiting for status to be reported. Could you have a look at it, please?

@apodhrad
Copy link
Contributor Author

Hi @rashmigottipati @jmrodri is there something how I can "unblock" this PR, please?

@apodhrad apodhrad force-pushed the OSDK-2303 branch 2 times, most recently from b2412e9 to e6a2f7c Compare June 9, 2022 14:31
@apodhrad
OSDK-2303: Scorecard testOutput is tightly coupled with storage mount…
4483d62 
…Path

Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
theishshah
theishshah approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
jmrodri
jmrodri approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

laxmikantbpandhare
laxmikantbpandhare approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@laxmikantbpandhare laxmikantbpandhare merged commit 87cdc50 into operator-framework:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@theishshah theishshah theishshah approved these changes

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@jmrodri jmrodri

@theishshah theishshah

@laxmikantbpandhare laxmikantbpandhare

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@apodhrad @rashmigottipati @jmrodri @theishshah @laxmikantbpandhare