Merge feature/run-bundle into master: Add FBC support to run bundle and run bundle-upgrade commands
#5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmigottipati
force-pushed
the
feature/run-bundle
branch
from
a154988
to
73dfd92
Compare
rashmigottipati
requested review from
everettraven
and removed request for
marc-obrien
There was a problem hiding this comment.
This looks good to me overall.
I would really like to see some tests added that reflect the test cases in the EP: https://github.com/operator-framework/enhancements/blob/master/enhancements/sdk-fbc-bundle-upgrade.md#test-plan
I think it would be okay if it was a follow-up but would be ideal if they were included in this PR.
There was a problem hiding this comment.
Since I've already reviewed the PRs that went into the feature branch, I'll leave this to @jmrodri and @joelanford.
jmrodri
approved these changes
Jun 8, 2022
|
/lgtm |
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
rashmigottipati
force-pushed
the
feature/run-bundle
branch
from
9103a93
to
2885f88
Compare
everettraven
added
the
release-blocker
VenkatRamaraju
pushed a commit
to VenkatRamaraju/operator-sdk
that referenced
this pull request
Jun 9, 2022
…-upgrade` subcommands (operator-framework#5809) * Implement File-Based Catalog support for `run bundle` and `run bundle-upgrade` command in SDK * Create a valid File-Based Catalog by generating bundle, package and channel blobs for a given bundle image * Generate a valid FBC if index image provided in the CLI is FBC - add bundle to index if bundle is not present in index * Infer the image type (SQLite/FBC) based on the image label and handle FBC scenarios accordingly * Validate the generated FBC and convert to a string format * Add a new registry pod container creation command to support FBC type and use new opm commands Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5593
Description of the change:
run bundleandrun bundle-upgradecommands by create a file-based catalog (FBC) on the fly by generating the bundle, package and channel blobs, if an index image is not provided by the user (i.e. for a default index imagequay.io/operator-framework/opm:latest) and serve it over a gRPC port.opm registry addandopm registry serve) that use SQLite under the hood will be called. So support for both (FBC/SQLite) exist at the moment. For more details, please refer to run bundle design proposal.For run bundle-upgrade: Handle upgrade for both scenarios when an operator bundle is installed using
run bundlecommand and also installed traditionally via OLM. For more details, please refer to run bundle upgrade design proposal.Motivation for the change:
#5593
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsSigned-off-by: rashmigottipati chowdary.grashmi@gmail.com