Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump envtest, golangci-lint, and kind #6088

Merged
merged 2 commits into from Oct 17, 2022

Conversation

everettraven
Copy link
Contributor

Description of the change:

  • bumps Makefile var K8S_VERSION to be 1.25.0 which bumps k8s version used by envtest to be 1.25.0
  • bumps golangci-lint to be 1.50.0 which is the latest and works with Go 1.19
  • bumps kind to 0.16.0 which is the latest and defaults to using k8s 1.25.2 as the node image
  • Adds ReadHeaderTimeout to http.Server creation logic for ansible.
    • Running make lint locally without this lead to linting errors stating that without the ReadHeaderTimeout there is the potential for a Slowloris attack.

Motivation for the change:

  • bumping SDK to support k8s 1.25.x

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
Copy link
Contributor Author

/hold

I need to add a changelog for the ansible changes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:22 Inactive
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:22 Inactive
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:22 Inactive
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:26 Inactive
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:26 Inactive
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:26 Inactive
@everettraven everettraven temporarily deployed to deploy October 14, 2022 21:26 Inactive
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven everettraven temporarily deployed to deploy October 17, 2022 13:39 Inactive
@everettraven
Copy link
Contributor Author

/hold cancel

/cc @jmrodri @laxmikantbpandhare

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@everettraven everettraven merged commit 7e77408 into operator-framework:master Oct 17, 2022
@everettraven everettraven deleted the bump-envtest branch October 17, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants