Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.25.x] updated code and made state as pass and throw suggestion instead of error for missing spec in CR #6266

Merged

Conversation

rashmigottipati
Copy link
Member

Cherry-pick of PR #6245

…rror for missing spec in CR. (operator-framework#6245)

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated test cases

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@rashmigottipati rashmigottipati merged commit 63935a4 into operator-framework:v1.25.x Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants