pkg/scaffold: fix hardcoded crd version #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have CRD and CR examples match, so examples work for new users. Fixes #689
openshift-ci-robot
added
size/XS
|
Hi @Brian-Williams. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hasbro17
approved these changes
Nov 2, 2018
AlexNPavel
pushed a commit
to AlexNPavel/operator-sdk
that referenced
this pull request
Nov 2, 2018
Have CRD and CR examples match, so examples work for new users. Fixes operator-framework#689
AlexNPavel
added a commit
that referenced
this pull request
Nov 2, 2018
* pkg/scaffold: remove TODO for metrics port (#679) * pkg/scaffold: fix hardcoded crd version (#690) Have CRD and CR examples match, so examples work for new users. Fixes #689 * Release versioning (#684) * release.sh: fix TOML_TMPL_FILE path * doc/release-versioning.md: update release versioning doc * pkg/scaffold/gopkgtoml,version: update branch to v0.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Use requested version in CRD example.
Motivation for the change:
Examples could mismatch on versions.
Closes #689